0.7.1 bug fixes - #25
Merged
Merged
Conversation
Vec<ChannelMessage>'s multi-message encoding routes every message
through the generic Message::encode, which deliberately omits the
type-tag byte for Open/Close (they're framed via their own dedicated
2-byte prefix on the single-message path instead). But the multi-message
decode loop always goes through the generic Message::decode, which has
no case for Open/Close at all, so it misread the untagged bytes as a
bogus type and errored ("Invalid message type to decode").
This only ever showed up once something started opening 2+ channels
close enough together to get batched into one write - every existing
test only ever sent one Open at a time. Fixed by never batching an
Open/Close with anything else in MessageIo::poll_outbound, rather than
changing the wire encoding itself.
The numberes generated by benchmarks in CI are pointless bc the runtime's performance is so variable. Also, it's really slow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.