Skip to content

docs(autopopulate): fix stale finally-comment; document upstream in class Attributes #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MilagrosMarin merged 1 commit into from
Jul 20, 2026
Merged

docs(autopopulate): fix stale finally-comment; document upstream in class Attributes #1510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/datajoint/autopopulate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ class AutoPopulate:
Query yielding keys to be populated. Default is join of FK parents.
jobs : Job
Job table (``~~table_name``) for distributed processing.
upstream : Diagram
Pre-restricted ancestor view for the current ``make(self, key)`` call
(property). Available only inside ``make()``; built lazily on first
access and memoized for the call. See the property docstring for
details.

Notes
-----
Expand Down Expand Up @@ -736,9 +741,11 @@ def _populate1(
return True
finally:
self.__class__._allow_insert = False
# Clear the per-make() upstream view so subsequent attribute
# access raises a clear error rather than silently using a
# stale trace from the previous make() call.
# Clear the per-make() upstream state: `_upstream = None` invalidates
# the memoized Diagram; `_upstream_key = None` restores the "outside
# make()" state so subsequent `self.upstream` access raises a clear
# error via the property guard rather than silently returning a stale
# trace from the previous call.
self._upstream = None
self._upstream_key = None

Expand Down
Loading