docs: fix misleading deprecation example in versioning guide#229
Merged
dimitri-yatsenko merged 1 commit intoJul 20, 2026
Merged
Conversation
The version-deprecated admonition example claimed `allow_direct_insert` is deprecated in favor of `dj.config['safemode']`. Both are wrong: allow_direct_insert is a current insert() parameter (guards direct inserts into auto-populated tables), and safemode is an unrelated setting (the delete/drop confirmation prompt). Replace with a generic old_method()/new_method() placeholder so the style example can't be read as a factual deprecation claim.
dimitri-yatsenko
added
the
documentation
MilagrosMarin
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
version-deprecatedadmonition example inabout/versioning.mdclaimedallow_direct_insertis deprecated in favor ofdj.config['safemode']. Both claims are incorrect:allow_direct_insertis not deprecated — it is a currentinsert()parameter (table.py:795, enforced attable.py:830) that guards direct inserts into auto-populated tables outside theirmake()method.safemodeis unrelated — it gates the delete/drop confirmation prompt (table.py:1064/1224), not inserts.Since this block only illustrates the admonition style, replace it with a generic
old_method()/new_method()placeholder so it can't be misread as a factual deprecation claim.