Skip to content

fix: columns with dots or brackets in their names are no longer reported missing - #1762

Closed
Shahzeb-DataEngineer wants to merge 1 commit into
datacontract:mainfrom
Shahzeb-DataEngineer:fix/1760-literal-column-names
Closed

Shahzeb-DataEngineer wants to merge 1 commit into
datacontract:mainfrom
Shahzeb-DataEngineer:fix/1760-literal-column-names

Conversation

@Shahzeb-DataEngineer

Copy link
Copy Markdown

Fixes #1760. Field resolution in the ibis check executor interpreted column names as nested paths, so a literal column named Rate.x or Amount [A] never matched and was reported missing. Resolution now prefers a literal column of that name before reading the name as a path.

…checks

Field resolution interpreted a column name as a nested path, splitting
on "." and treating "[...]" as array or map hops, so a literal column
named "Rate.x" or "Amount [A]" never matched and was reported missing.
Resolution now prefers a literal column of that name before reading
the name as a path.

Signed-off-by: Shahzeb Ali <126076773+Shahzeb-DataEngineer@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 20, 2026 16:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@jschoedl

jschoedl commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

This PR seems to be part of a code generation pipeline with little human oversight and is closed preemptively, as such contributions are typically consuming much maintainer time with little gain.

Note that we generally accept AI-assisted contributions, but we expect contributors to personally understand the issue, decide for a proper fix, and put reasonable effort into verifying the AI-generated code.

If you want to suggest an improvement or bug fix, please create an issue. Pull Requests by your account in the next 2 weeks are likely to get closed as well.

(This message was sent automatically.)

@jschoedl jschoedl closed this Oct 20, 2026
@Shahzeb-DataEngineer

Copy link
Copy Markdown
Author

Hi @jschoedl, understood, and I apologise for the noise. The fix was based on the confirmed report in #1760, but I respect your policy and the signal it sent. I will not open further PRs here. Thanks for the clear note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field names reported as missing when present but inaccurately parsed (DuckDB)

3 participants