Repository navigation
Conversation
kamathramu87
marked this pull request as ready for review
October 13, 2026 08:44
…/reject-duplicate-contract-yaml-keys # Conflicts: # CHANGELOG.md
The error's first location used to be the start of the enclosing mapping, often line 1 of the contract. It now names the key and the line where it first appears, followed by the duplicate.
Collaborator
|
Thank you for the PR! I applied some minor changes, otherwise LGTM :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate YAML mapping keys currently overwrite earlier values silently, so a repeated
required,quality, or contract identity field can change what gets validated. Reject duplicate explicit keys with source/line diagnostics while preserving YAML merge overrides and date strings.Validation: 48 relevant tests pass; Ruff lint and format checks pass.