Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions statvar_imports/us_newyork/ny_diabetes/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,18 @@
"input_files/ny_percentage_of_adults_with_diagnosed_diabetes_by_county_2016_data.csv",
"input_files/ny_percentage_of_adults_with_diagnosed_diabetes_by_county_2018_data.csv",
"input_files/ny_percentage_of_adults_with_diagnosed_diabetes_by_county_2021_data.csv"
]

],
"cron_schedule": "0 0 1 * *",
"resource_limits": {"cpu": 4, "memory": 8, "disk":100},
"config_override": {
"invoke_import_validation": true,
"invoke_import_tool": true,
"invoke_differ_tool": true,
"skip_input_upload": false,
"skip_gcs_upload": false,
"cleanup_gcs_volume_mount": false
}
}
Comment on lines +35 to +45

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation of the newly added fields (cron_schedule, resource_limits, and config_override) is inconsistent with the rest of the file. Standardizing the indentation to match the surrounding 4-space hierarchy improves readability and maintainability.

            "cron_schedule": "0 0 1 * *",
            "resource_limits": {
                "cpu": 4,
                "memory": 8,
                "disk": 100
            },
            "config_override": {
                "invoke_import_validation": true,
                "invoke_import_tool": true,
                "invoke_differ_tool": true,
                "skip_input_upload": false,
                "skip_gcs_upload": false,
                "cleanup_gcs_volume_mount": false
            }
        }

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

]
}