Added goldens#2107
Open
shvngisingh wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces validation configuration and golden data files for the FAO currency and exchange rate import. Specifically, it adds golden_observation.csv and golden_summary.csv to establish baseline datasets, registers the validation configuration in manifest.json, and defines the validation rules in validation_config.json using the GOLDENS_CHECK validator. There are no review comments, and I have no additional feedback to provide.
Contributor
|
Pls add import name in PR title |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Goldens to fao_currency_statvar import.
dc : https://datacommons.org/browser/dc/base/FAO_Currency_statvar
autopush: https://autopush.datacommons.org/browser/dc/base/FAO_Currency_statvar
prod bucket : https://pantheon.corp.google.com/storage/browser/datcom-prod-imports/statvar_imports/fao_currency_and_exchange_rate/fao_currency_statvar/FAO_Currency_statvar?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&mods=-monitoring_api_staging&project=datcom-204919
cns : https://data.corp.google.com/cnsviewer/file?query=%2Fcns%2Fjv-d%2Fhome%2Fdatcom%2Fv3_mcf%2Ffao%2Flatest%2F&user=