Adding goldens to NCES_Bachelors_Degree_By_Field_Import and NCES_HBCU_Enrollment_Import - #2096
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces golden data files and a validation configuration for NCES bachelor's degree imports, enabling automated checks for both male and female educational attainment datasets. A critical issue was identified in validation_config.json where the golden file path for check_goldens_male_latest_observations was incorrectly configured to point to a summary report instead of the observations file.
|
There are two imports each for male and female. Each import is having 351 entries in summary golden sets. Please check if both the files are having same SVs, then combine both of them. |
|
|
LGTM |
…://github.com/smarthg-gi/data into goldens_NCES_Bachelors_Degree_By_Field_Import
Imports:
NCES_Bachelors_Degree_By_Field_Import
NCES_HBCU_Enrollment_Import
This PR includes:
Added goldens with 0.1% increase in threshold
PR Checklist: https://docs.google.com/spreadsheets/d/1_vmnJ9eFYFCq0JYikWSvMDoDY1DLxphRlohDOhuOdrE/edit?resourcekey=0--hVe9fbOAp_kCat_ElGcKg&gid=0#gid=0