Skip to content

chore(ci): retain failed test output - #1089

Merged
izadoesdev merged 1 commit into
mainfrom
codex/ci-failure-output
Oct 6, 2026
Merged

izadoesdev merged 1 commit into
mainfrom
codex/ci-failure-output

Conversation

@izadoesdev

@izadoesdev izadoesdev commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Hosted AI test failures can lose their assertion details in passing-test output. This slice limits Turbo to failed-task output and Bun's AI suites to failures, retaining isolation, discovery, integration flags and nonzero exits.

Validation: formatting, root lint/types, 101 existing memory tests (170 assertions), 20 API route tests and 10 conversation tests. A disposable reporter comparison retains the same two passes, one deliberate failure, failure text and exit code 1. Normal frozen-lockfile and commit hooks passed.

Known overlap: #1073 owns AI package exports already present in main; this slice changes only test scripts. No stacked dependency. Neither owned path matches SDK/CDN or npm release workflows; ordinary main Docker image workflows remain eligible.

AI assistance was used for implementation and review.


Summary by cubic

Preserves assertion details from failed test runs by limiting CI and Bun test output to failures only.

  • Adds --output-logs=errors-only to the CI test and integration test steps.
  • Switches the @ai-sdk test scripts to --only-failures so failed tests retain full output.

Written for commit c8cfa0d. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Tests
    • Test runs now show errors and failures more selectively, keeping routine test output concise.

@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dashboard Ready Ready Preview Oct 6, 2026 6:56am UTC
databuddy-status Ready Ready Preview Oct 6, 2026 6:56am UTC
documentation Ready Ready Preview Oct 6, 2026 6:56am UTC

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 96184fd8-f20b-4e45-9b30-cc07ebc11874

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2c7e2801-ee48-4b83-8412-3cc5ac92e7c9
📥 Commits

Reviewing files that changed from the base of the PR and between a0d6116 and b465503.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • packages/ai/package.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: Greptile Review
  • GitHub Check: Test
  • GitHub Check: Dashboard Playwright
🧰 Additional context used
📚 Code guidelines (4)
.cursor/rules/performance.mdc — auto-discovered
.cursor/rules/ui-guidelines.mdc — auto-discovered
.cursor/rules/01-MUST-DO.mdc — auto-discovered
AGENTS.md — auto-discovered
📓 Path-based instructions (4)
Source excerpt: When you discover a new performance improvement, optimization pattern, or fix a performance regression, add a concise bullet to the relevant section below in the same session.

📄 CodeRabbit inference engine (.cursor/rules/performance.mdc)

Files:

  • packages/ai/package.json
Source excerpt: MUST use Tailwind CSS defaults unless custom values already exist or are explicitly requested Source excerpt: MUST use motion/react (formerly framer-motion) when JavaScript animation is required Source excerpt: SHOULD use tw...

📄 CodeRabbit inference engine (.cursor/rules/ui-guidelines.mdc)

Files:

  • packages/ai/package.json
Source excerpt: description: Basic guidelines for the project so vibe coders don't fuck it up globs: alwaysApply: true when using 'text-right', always add 'text-balance' so its not ugly Source excerpt: description: Basic guidelines for the...

📄 CodeRabbit inference engine (.cursor/rules/01-MUST-DO.mdc)

Files:

  • packages/ai/package.json
Source excerpt: Keep workspace dependencies explicit in each package's `package.json`; typecheck can pass locally from hoisting while CI or package boundaries fail.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • packages/ai/package.json
🔇 Additional comments (2)
.github/workflows/ci.yml (1)

162-162: LGTM!

Also applies to: 179-179

packages/ai/package.json (1)

46-47: LGTM!


Walkthrough

The CI workflow adds --output-logs=errors-only to its main and integration test commands. The package test scripts add --only-failures to their Bun test commands.

Changes

Test output options

Layer / File(s) Summary
Test command output options
.github/workflows/ci.yml, packages/ai/package.json
The CI main and integration test commands add --output-logs=errors-only. Both package test scripts add --only-failures.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b4655

The output changes retain failed-test details without suppressing test execution or failure status. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: retaining failed test output in CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@unkey-deploy

unkey-deploy Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Unkey Deploy

Name Status Preview Inspect Updated (UTC)
links (preview) Ready Visit Preview Inspect Oct 6, 2026 6:54am

@izadoesdev

Copy link
Copy Markdown
Member Author

@coderabbitai full review

Please review final head b4655034ec333800d567349f5d00b364111eb5ec. This is a new independent two-file CI logging slice, so it needs its first full source review. Test commands retain their isolation, discovery, integration flags and exit codes. Formatting, root lint/types, 131 existing tests and a disposable failing-output comparison passed. Known overlap #1073 changes AI package exports already in main; those exports are preserved.

@izadoesdev

Copy link
Copy Markdown
Member Author

@greptileai

Please re-review final head b4655034ec333800d567349f5d00b364111eb5ec. Valid findings have been fixed and validated; intentional copy choices and optional refactors are explained in their resolved threads. Please check the final diff for remaining actionable issues.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Changes test runner behavior in CI and local test scripts.

The final PR appears safe to merge; no actionable issue remains in its two changed files.

What we checked:

  • CI still reaches Turbo: Both root test scripts invoke Turbo, so CI passes the new option to the test task runner.

Summary

The PR tunes CI and AI-package test output so failures are easier to focus on.

  • CI test runs show error-only task logs.
  • AI-package tests focus their output on failures.

Reviews (2) · Last reviewed commit: "chore(ci): retain failed test output"

@izadoesdev

Copy link
Copy Markdown
Member Author

@greptileai

Please re-review final head c8cfa0d8ed47f1de2bc7b7366e1336d107af3aa5. Valid findings have been fixed and validated; intentional copy choices and optional refactors are explained in their resolved threads. Please check the final diff for remaining actionable issues.

This branch was successfully deployed

4 active deployments
Preview – documentation — c8cfa0d8 Deployed Oct 6, 2026 by vercel[bot]
Preview – dashboard — c8cfa0d8 Deployed Oct 6, 2026 by vercel[bot]
Preview – databuddy-status — c8cfa0d8 Deployed Oct 6, 2026 by vercel[bot]
links - preview — c8cfa0d8 Deployed Oct 6, 2026 by unkey-deploy[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant