Skip to content

fix(rpc): explain how to retry unavailable billing - #1064

Merged
izadoesdev merged 1 commit into
mainfrom
codex/billing-retry
Oct 7, 2026
Merged

izadoesdev merged 1 commit into
mainfrom
codex/billing-retry

Conversation

@izadoesdev

@izadoesdev izadoesdev commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Billing outages now tell the user to try again in a moment. The existing 503 status, 30-second retry hint, and original error cause are preserved.

This is one coherent commit changing one message in packages/rpc/src/orpc.ts, based on current main after merged #1063 and #1074. All 22 relevant RPC billing and dashboard error tests, scoped formatting, root lint, and types passed. Normal hooks remain enabled. Final-head configured reviews and native CI are required before merge.

AI-assisted maintainer-owned cleanup.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the message shown when billing is unavailable to suggest trying again in a moment.

@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dashboard Ready Ready Preview Oct 7, 2026 9:10am UTC
databuddy-status Ready Ready Preview Oct 7, 2026 9:10am UTC
1 Skipped Deployment
Project Deployment Actions Updated
documentation Skipped Skipped Oct 7, 2026 9:10am UTC

@unkey-deploy

unkey-deploy Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Unkey Deploy

Name Status Preview Inspect Updated (UTC)
links (preview) Ready Visit Preview Inspect Oct 6, 2026 11:28am

@vercel
vercel Bot temporarily deployed to Preview – documentation October 5, 2026 01:13 Inactive
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 6b7d8074-3f76-44a9-acb2-f6745983e8df
📥 Commits

Reviewing files that changed from the base of the PR and between 9f19fec and 3a98a97.

📒 Files selected for processing (1)
  • packages/rpc/src/orpc.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: Greptile Review
  • GitHub Check: Dashboard Playwright
  • GitHub Check: Analyze
  • GitHub Check: Test
  • GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📚 Code guidelines (3)
.cursor/rules/performance.mdc — auto-discovered
.cursor/rules/ui-guidelines.mdc — auto-discovered
.cursor/rules/01-MUST-DO.mdc — auto-discovered
📓 Path-based instructions (3)
Source excerpt: When you discover a new performance improvement, optimization pattern, or fix a performance regression, add a concise bullet to the relevant section below in the same session.

📄 CodeRabbit inference engine (.cursor/rules/performance.mdc)

Files:

  • packages/rpc/src/orpc.ts
Source excerpt: MUST use Tailwind CSS defaults unless custom values already exist or are explicitly requested Source excerpt: MUST use motion/react (formerly framer-motion) when JavaScript animation is required Source excerpt: SHOULD use tw...

📄 CodeRabbit inference engine (.cursor/rules/ui-guidelines.mdc)

Files:

  • packages/rpc/src/orpc.ts
Source excerpt: description: Basic guidelines for the project so vibe coders don't fuck it up globs: alwaysApply: true when using 'text-right', always add 'text-balance' so its not ugly Source excerpt: description: Basic guidelines for the...

📄 CodeRabbit inference engine (.cursor/rules/01-MUST-DO.mdc)

Files:

  • packages/rpc/src/orpc.ts
🔇 Additional comments (1)
packages/rpc/src/orpc.ts (1)

175-175: LGTM!


Walkthrough

The billing-unavailable error message now includes “Try again in a moment.” Its status, retry data, and cause remain unchanged.

Changes

Billing-unavailable error

Layer / File(s) Summary
Update billing-unavailable message
packages/rpc/src/orpc.ts
The error message adds “Try again in a moment.” The status, retry data, and cause remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 3a98a

The billing-unavailable message adds a retry suggestion without an indicated change to retry behavior. No material mergeability risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding retry guidance to the billing-unavailable error message.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@izadoesdev

Copy link
Copy Markdown
Member Author

@coderabbitai full review

Please review the complete one-file billing retry copy slice at e41c859a57130c48903f5f1e7b830de14e14ee9c against published parent ab467429acb9c577d2ec9ea494893bdad9bb460e. This remains a draft depending on #1063 and held #1062. Formatting, lint, types, 12 billing/RPC and 8 user-facing error tests, and all 32 normal pre-push tasks passed. The typed 503 status and retryAfter metadata are unchanged.

@izadoesdev

Copy link
Copy Markdown
Member Author

@greptileai review

Please review the complete one-file retry copy slice at e41c859a57130c48903f5f1e7b830de14e14ee9c against published billing parent ab467429acb9c577d2ec9ea494893bdad9bb460e. It remains a draft depending on #1063 and held #1062.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 1 minute.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Updates an error message shown to users.

This message-only change appears safe to merge.

What we checked:

  • Billing errors stay recognizable: The error type and code stay unchanged. The checked tests match the code and status rather than the old message.

Summary

Updates the billing-outage message in packages/rpc/src/orpc.ts to tell users to try again in a moment.

  • Billing-unavailable errors now tell RPC callers to try again in a moment.

Reviews (2) · Last reviewed commit: "fix(rpc): explain how to retry unavailab..." · Reviewed by Greptile

@izadoesdev

Copy link
Copy Markdown
Member Author

@coderabbitai full review

Retrying once after the reported one-minute included-review reset. Please review the complete one-file retry slice on e41c859a57130c48903f5f1e7b830de14e14ee9c against billing parent ab467429acb9c577d2ec9ea494893bdad9bb460e. This remains a draft depending on #1063 and held #1062.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@izadoesdev
izadoesdev force-pushed the codex/billing-access branch 2 times, most recently from 3a48b47 to fead8aa Compare October 7, 2026 07:37
Base automatically changed from codex/billing-access to main October 7, 2026 08:13
@izadoesdev
izadoesdev force-pushed the codex/billing-retry branch from e41c859 to 3a98a97 Compare October 7, 2026 09:09
@vercel
vercel Bot temporarily deployed to Preview – documentation October 7, 2026 09:09 Inactive
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Observability score · 31

poor · unchanged against main · no regression

1 instrumented · 0 partial · 8 dark

Fix first (3)

evlog map v0.8.0 · how the score works · what each check expects

@izadoesdev
izadoesdev marked this pull request as ready for review October 7, 2026 09:09
@izadoesdev

Copy link
Copy Markdown
Member Author

@greptileai review

Please review final head 3a98a97 against actual main 9f19fec after merged #1063 and #1074. This slice changes only the billing-unavailable user message; 503 status, 30-second retry metadata, and original error cause remain intact. All 22 relevant tests, formatting, root lint and types passed.

@izadoesdev

Copy link
Copy Markdown
Member Author

@coderabbitai full review

Please review the single scoped file on final head 3a98a97 against actual main 9f19fec. This is one message change in packages/rpc/src/orpc.ts, preserving 503 status, retry metadata, and original cause. All 22 relevant tests, formatting, root lint, types and normal hooks passed. Prior reviews on feature-parent heads do not establish this final-head coverage.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@izadoesdev
izadoesdev merged commit 71c24c2 into main Oct 7, 2026
27 checks passed
@izadoesdev
izadoesdev deleted the codex/billing-retry branch October 7, 2026 09:15

This branch was successfully deployed

3 active (1 outdated) and 1 inactive deployments
Preview – dashboard — 3a98a973 Deployed Oct 7, 2026 by vercel[bot]
Preview – databuddy-status — 3a98a973 Deployed Oct 7, 2026 by vercel[bot]
Preview – documentation — 3a98a973 Deployed Oct 7, 2026 by vercel[bot]
links - preview — e41c859a Deployed Oct 6, 2026 by unkey-deploy[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant