disable smart routing for all subcommands on cc and codex - #558
Merged
Conversation
ucode codex app even if the env var is set
ucode codex app even if the env var is set
david-siqi-liu
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only 2 cmds should invoke smart routing:
ug codexorug claudewhich launches a tui that will smart route the first promptug codex -- <prompt>orug claude -- <prompt>which will launch a tui with prompt prepopulated and then smart route it.no other subcommands should trigger smart routing, even if the environment variable is set. this came up because
isaac codex appwhich automatically hasenable_smart_routing_v2=1set tried to invoke smart routing...this was missed in #502 because i didn't explicitly test
ug codex appwhich apparently functions diff fromug codex app-servertesting:
ENABLE_SMART_ROUTING_V2=1 uv run ug codex-> invokes smart routingENABLE_SMART_ROUTING_V2=1 uv run ug claude-> invokes smart routingENABLE_SMART_ROUTING_V2=1 uv run ug codex -- 'hi'-> invokes smart routingENABLE_SMART_ROUTING_V2=1 uv run ug claude -- 'hi'-> invokes smart routingENABLE_SMART_ROUTING_V2=1 uv run ug codex app-> does NOT invoke smart routingENABLE_SMART_ROUTING_V2=1 uv run ug codex app-server-> does NOT invoke smart routingENABLE_SMART_ROUTING_V2=1 uv run ug codex update-> does NOT invoke smart routingENABLE_SMART_ROUTING_V2=1 uv run ug codex --model system.ai.glm-5-2-> does NOT invoke smart routing