-
Notifications
You must be signed in to change notification settings - Fork 71
[AIGTWY-4564] Add Codex parent schema discovery #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andy-xu-db
wants to merge
10
commits into
main
Choose a base branch
from
aigtwy-4564-codex-parent-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f914af7
Add Claude parent schema discovery
andy-xu-db 7e57c4c
Merge remote-tracking branch 'origin/main' into resolve/aigtwy-4564-c…
andy-xu-db 551dc3b
Address parent schema review feedback
andy-xu-db 2a50e7a
Inline model routing header selection
andy-xu-db e308bea
Simplify model routing header constants
andy-xu-db 74a278d
Share model service routing headers
andy-xu-db ce55c11
Add Codex parent schema discovery
andy-xu-db 7c90344
Support Responses-capable Bedrock services in Codex
andy-xu-db 1d4b1b6
Revert Codex Bedrock MPS support
andy-xu-db eb476bc
Remove unused Codex header cleanup paths
andy-xu-db File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| """Headers used to route model service requests.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from ucode.constants import MODEL_PROVIDER_SERVICE_HEADER, MODEL_SERVICE_PARENT_SCHEMA_HEADER | ||
|
|
||
|
|
||
| def model_service_routing_headers( | ||
| provider: str | None, | ||
| parent_schema: str | None, | ||
| ) -> dict[str, str]: | ||
| # A provider selects one MPS; a parent discovers Model Services. | ||
| if provider: | ||
| return {MODEL_PROVIDER_SERVICE_HEADER: provider} | ||
| if parent_schema: | ||
| return {MODEL_SERVICE_PARENT_SCHEMA_HEADER: parent_schema} | ||
| return {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| """Shared string validation helpers.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
|
|
||
| def is_valid_catalog_schema(value: str) -> bool: | ||
| """Return whether value is a safe ``<catalog>.<schema>`` reference.""" | ||
| parts = value.split(".") | ||
| return len(parts) == 2 and all( | ||
| part | ||
| and part.isprintable() | ||
| and not any(character.isspace() or character == "/" for character in part) | ||
| for part in parts | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add ex like in anthropic