Skip to content

[E2E] Add timestamp to unique name - #2119

Merged
rclarey merged 2 commits into
mainfrom
e2e-bundles-with-timestamp
Aug 24, 2026
Merged

[E2E] Add timestamp to unique name#2119
rclarey merged 2 commits into
mainfrom
e2e-bundles-with-timestamp

Conversation

@rclarey

@rclarey rclarey commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Changes

Add a timestamp to the unique name given to E2E directories. This allows a cleanup job to run and delete directories older than a given threshold

Tests

None

@rclarey
rclarey deployed to test-trigger-is August 14, 2026 12:28 — with GitHub Actions Active
@rclarey
rclarey deployed to test-trigger-is August 14, 2026 12:28 — with GitHub Actions Active
@rugpanov

rugpanov commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

🤖 Integration tests ✅ all 35 test jobs passed for c3b0f1b0.
View run

@rugpanov rugpanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — reviewed the change to getUniqueResourceName. Name-length and charset constraints are fine (worst case well under the 4096-byte job-name limit), collision resistance is unchanged/improved, and no existing test parses the name format, so this is backward-compatible.

One non-blocking suggestion: the vscode_integration_test_<ms>_<uuid> format is now effectively a contract consumed by the external cleanup job. A short comment pointing at that job (and, ideally, a tiny test pinning the format) would guard against a future refactor silently breaking cleanup. Legacy UUID-only directories created before this merge won't carry a parseable timestamp, so the cleanup job will need to handle those separately.

@rugpanov

rugpanov commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review suggestions (non-blocking) — no blocking issues found across the review.

  1. The vscode_integration_test_<ms>_<uuid> format is now effectively a contract for the external cleanup job. A comment referencing that job (and a small test pinning the format) would prevent a future refactor silently breaking cleanup.
  2. Legacy UUID-only directories created before this change carry no parseable timestamp, so the cleanup job needs to handle them separately.

@rclarey
rclarey enabled auto-merge (squash) August 24, 2026 13:32
@rclarey
rclarey deployed to test-trigger-is August 24, 2026 13:32 — with GitHub Actions Active
@rclarey
rclarey deployed to test-trigger-is August 24, 2026 13:32 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/vscode

Inputs:

  • PR number: 2119
  • Commit SHA: 8c2acfc18f0da8190f361fc3e4696d68bdee8abb

Checks will be approved automatically on success.

@rclarey
rclarey merged commit d2b2c5e into main Aug 24, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants