ci: stop secondary fork-PR checks from failing (#831)#852
Merged
Conversation
The fork verification (#849) showed 3 checks still red on fork PRs — pre-existing (also red on the original #671), separate from the cache fix, all rooted in GitHub's fork restrictions: - skip-integration-tests-pr / skip-kernel-e2e-pr post synthetic-success check-runs, needing checks:write. On fork PRs GitHub forces GITHUB_TOKEN to read-only regardless of the declared permission, so checks.create 403s ('Resource not accessible by integration'). Swallow the 403 ONLY for forks (github.event.pull_request.head.repo.fork) so the poster doesn't show a spurious failure; the REAL required checks are posted by the merge_group run (base context, full perms) when a maintainer queues the PR — the fork's code is genuinely integration-tested there. Non-fork/other errors still fail loudly. - test-with-coverage runs the e2e suite against a live warehouse and needs the azure-prod secrets, which forks never get (Secret source: None) — so it could only fail on a fork. Skip it on fork PRs; the real coverage gate runs on the merge_group transient branch (secrets present), which is what protects main. Same-repo PRs and merge_group are unaffected by all three changes. Refs #831 Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
vikrantpuppala
added a commit
to vikrantpuppala/databricks-sql-python
that referenced
this pull request
Jul 9, 2026
…tabricks#831) Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the offline-CI fix (#845/#848/#850/#851) turned the 37 unit/lint/type checks green on fork PRs, 3 checks remained red on the fork verification PR (#849). They are pre-existing (also red on the original fork PR #671), unrelated to the cache work, and all rooted in GitHub's fork restrictions:
skip-integration-tests-pr/skip-kernel-e2e-prpost synthetic-success check-runs (checks.create), which needchecks: write. On fork PRs GitHub forcesGITHUB_TOKENto read-only regardless of the declared permission, so the call 403s (Resource not accessible by integration). Fix: swallow the 403 only for forks (head.repo.fork) so the poster doesn't show a spurious failure. The real required checks (Python Proxy Tests / thrift|kernel,Kernel E2E) are posted by themerge_grouprun — which runs in the base-repo context with full permissions and secrets, checks out the queue branch (fork's merged code), and dispatches the actual proxy tests. So the fork's code is integration-tested, at merge-queue time. Non-fork and other errors still fail loudly.test-with-coverageruns the e2e suite against a live warehouse and needs theazure-prodsecrets, which forks never receive (Secret source: None) — so it could only fail on a fork. Skip it on fork PRs; the real coverage gate runs on themerge_grouptransient branch (secrets present), which is what actually protectsmain.Same-repo PRs and
merge_groupare unaffected by all three changes.Before / after (fork PR)
Test plan
test-with-coverageskips on the fork; no red checks remain.Maintainer note
For a fork PR to be addable to the merge queue, branch protection must allow the required checks (
Python Proxy Tests / *,Kernel E2E, coverage) to be satisfied by themerge_grouprun rather than at PR time. Please confirm the ruleset is in merge-queue mode for these — this is the standing branch-protection follow-up for #831.Refs #831
This pull request and its description were written by Isaac.