Skip to content

fix: default geospatial results to strings - #546

Merged
cathleeny merged 1 commit into
mainfrom
cathleeny/geospatial-default-off
Oct 19, 2026
Merged

cathleeny merged 1 commit into
mainfrom
cathleeny/geospatial-default-off

Conversation

@cathleeny

@cathleeny cathleeny commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Default enableGeoSpatialSupport to false so kernel connections, including automatic Reyden recovery, retain WKT/EWKT strings. Explicit true still returns native geospatial results.
  • Update documentation and default-mode unit expectations. No kernel pin changes.

Validation

  • Build, formatting, and all 1,431 unit tests passed.
  • Live staging Reyden/DBSQL: all 48 cases passed in omitted, false, and true modes; every large result checked all 150,007 rows with external delivery confirmed.
  • Reyden/DBSQL comparator: 10/10 match. Existing geospatial E2E: 10 Reyden and 20 DBSQL tests passed.

Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
@cathleeny
cathleeny marked this pull request as ready for review October 19, 2026 20:47

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@cathleeny
cathleeny added this pull request to the merge queue Oct 19, 2026
@cathleeny
cathleeny removed this pull request from the merge queue due to a manual request Oct 19, 2026
@cathleeny
cathleeny added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 1fe8598 Oct 19, 2026
25 checks passed

This branch was successfully deployed

1 active deployment
azure-prod — 2f049e11 Deployed Oct 19, 2026 by cathleeny via e2e-test (24) #1670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant