Repository navigation
Conversation
dumpRootSchema pruned every field whose path ended in ".resources", which also dropped python.resources and experimental.python.resources (a []string list of loader functions) while their siblings were listed. Prune by type instead (config.Resources / *config.Resources), so only the root, targets.* and environments.* resource trees are skipped. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/bundle/refschema/DMS=: branch ✅ | main (2534bb0) ❌ | latest (v1.23.0) ❌main (2534bb0): latest (v1.23.0): TestAccept/bundle/refschema/DMS=true: branch ✅ | main (2534bb0) ❌ | latest (v1.23.0) ❌main (2534bb0): latest (v1.23.0): |
Collaborator
Integration test reportCommit: 2b2fb74
Top 3 slowest tests (at least 2 minutes):
|
pietern
marked this pull request as ready for review
November 5, 2026 08:49
pietern
requested review from
andrewnester and
denik
and removed request for
andrewnester
November 5, 2026 08:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle debug refschemadroppedpython.resourcesandexperimental.python.resourcesbecause it skipped every path ending in.resources. It now skips theResourcestype instead.Why
Filter added in #7189.
Tests
acceptance/bundle/refschemagains exactly the four missing lines.This pull request and its description were written by Isaac.