Repository navigation
ssh: record the serverless environment version in tunnel telemetry - #7265
Merged
Merged
Conversation
The CLI default is still environment 4, and moving it to 5 is planned once the driver's sandbox port forwarding reaches every region. The tunnel event has no environment field today, so neither opt-in adoption nor the effect of the flip can be measured. Send the environment version the server job is submitted with. The submit path and the event now read it from one helper, so the two cannot drift. Dedicated clusters and custom base environments leave it unset. The matching proto field lands in universe separately; ingestion drops the field until then. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 3fd3381
Top 3 slowest tests (at least 2 minutes):
|
…try-environment-version # Conflicts: # experimental/ssh/internal/client/client.go
rclarey
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
environment_versionto the ssh tunnel telemetry event. It holds the serverless environment version the server job is submitted with: the--environment-versionvalue or the default. It is unset for dedicated clusters and for a custom base environment. The job submit path and the event now read the value from one helper.Why
The tunnel's default is still environment 4. Moving it to 5 is planned once the REPL sandbox port forwarding reaches every region (DECO-28307). The event has no environment field today, so neither opt-in adoption nor the effect of the flip can be measured.
Tests
go test ./acceptance -run TestAccept/sshpasses, and the submittedenvironment_versionis unchanged.This pull request and its description were written by Isaac.