Skip to content

Add acceptance coverage for BOM notebook deletion badness #7247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janniklasrose wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add acceptance coverage for BOM notebook deletion badness #7247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions acceptance/bundle/sync/replace-node-type/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,16 @@ Uploaded plain.sql
>>> list
NOTEBOOK bom
FILE plain.sql

=== Remove both local files and sync again

>>> [CLI] bundle sync --output text
Action: DELETE: bom.sql, plain.sql
Deleted bom.sql
Deleted plain.sql
Initial Sync Complete

=== BUG: bom remains after sync reports deleting bom.sql

>>> list
NOTEBOOK bom
7 changes: 7 additions & 0 deletions acceptance/bundle/sync/replace-node-type/script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,10 @@ trace list
title "Sync replaces both\n"
trace $CLI bundle sync --output text 2>&1 | sort
trace list

title "Remove both local files and sync again\n"
rm bom.sql plain.sql
trace $CLI bundle sync --output text 2>&1 | sort

title "BUG: bom remains after sync reports deleting bom.sql\n"
trace list
2 changes: 2 additions & 0 deletions acceptance/bundle/sync/replace-node-type/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
Badness = "After a BOM-prefixed SQL notebook is removed locally, sync reports deleting bom.sql but leaves the remote notebook bom because the sync snapshot retains the .sql extension."

Cloud = true
Env.MSYS_NO_PATHCONV = "1"
Ignore = [".databricks"]
Loading