Repository navigation
Support file selectors in pipelines run - #7184
Open
chenyuem-db wants to merge 1 commit into
Open
chenyuem-db wants to merge 1 commit into
chenyuem-db wants to merge 1 commit into
Conversation
Collaborator
Integration test reportCommit: 9fd46d5
Top 6 slowest tests (at least 2 minutes):
|
chenyuem-db
force-pushed
the
chenyuem-db/pipeline-refresh-by-file
branch
2 times, most recently
from
October 28, 2026 17:02
0824056 to
652cd9e
Compare
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=1 unreleased=0 coverage=0 failing=0
TestAccept/pipelines/run/refresh-flags: branch ✅ | main (e9687c1) ❌ | latest (v1.22.1) ❌main (e9687c1): latest (v1.22.1): same output as main (e9687c1) |
chenyuem-db
force-pushed
the
chenyuem-db/pipeline-refresh-by-file
branch
from
October 28, 2026 22:30
ae8800b to
9fd46d5
Compare
chenyuem-db
marked this pull request as ready for review
October 29, 2026 22:08
chenyuem-db
requested review from
a team,
jefferycheng1,
kanterov and
lennartkats-db
as code owners
October 29, 2026 22:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Support source files in
pipelines run --refreshand--full-refresh. Local paths resolve through the bundle sync configuration, including notebook naming and exclusions; absolute/Workspace/paths are also accepted.The CLI sends deployed workspace paths in
refresh_selection_by_pathorfull_refresh_selection_by_path. The backend selects the tables whose definition paths match. GetUpdate echoes those selectors, and the CLI summary shows the selected source paths.Each flag accepts either table names or files. Mixing both within one flag fails before a restart can cancel the running update; using different selector types across the two flags is supported. Existing table selectors remain supported:
./requires a file, and backticks force table interpretation for ambiguous names. Path resolution follows the effective bundle sync mode, including precedence over deprecated source-linked settings. A bare table name remains valid when a local directory has the same name;./explicitly selects a path. Unresolved immutable-folder paths require an absolute/Workspace/path.Why
Let users refresh all tables defined in a source file without enumerating table names, as described in the SDP Turbo CLI PRD. Local changes must be deployed first.
This PR covers file-based refresh execution and source-path reporting. The PRD requirement to display the actual selected table-name list is not implemented. This remains an outstanding requirement; displaying the file paths does not fulfill it.
Tests
Verified the deployment-mode and table/directory regressions fail before the fix and pass afterward. Current local validation passed
go test ./cmd/pipelines ./bundle/run ./libs/testserver, pipeline-run and bundle-run acceptance tests without update mode, and./task fmt,./task checks, and./task lint.Local validation retains SDK v0.191.0 and temporarily uses
golang.org/x/net v0.61.0because the internal proxy blocked v0.62.0. The temporary dependency change is removed before committing; this PR retains main's v0.62.0 and has no dependency diff. CI on the new commit must validate the official dependency set. No manual live-workspace refresh was performed.Implementation and PR description prepared with Codex.