Repository navigation
Conversation
Collaborator
✅ Integration test reportCommit: 1157cb7
Top 3 slowest tests (at least 2 minutes):
|
Contributor
|
This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled. |
Each --watch step becomes a separate `databricks sync` run, so the tests now also cover the snapshot being saved and reloaded between runs, and they run locally against the testserver as well as on cloud. TestSyncIncrementalFileSync stays in integration/ to cover --watch. Co-authored-by: Isaac <no-reply@databricks.com>
macOS CI runs bash 3.2, which has no &>>. On Windows jq ends lines with CRLF, so the recursive remote listing passed "dir1\r" to workspace list. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/port-sync-integration-tests
branch
from
November 6, 2026 09:18
67338bb to
b893822
Compare
Contributor
|
Commit: Regression test reportSelected 6 changed tests (limit=20, 0 not selected) 6 tests: regression=0 unreleased=0 coverage=6 failing=0
|
Restore two checks from the deleted integration tests: the snapshot after a plain .py upload, and the snapshot's host and remote_path. Record as Badness that sync reports "Deleted dir1" for a non-empty folder it keeps. Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Port the
integration/cmd/synctests to acceptance tests underacceptance/cmd/sync-incrementalandacceptance/cmd/sync-remote-path. Each--watchstep becomes a separatedatabricks syncrun.TestSyncIncrementalFileSyncstays inintegration/as the only coverage for--watch.Why
The
integration/tree is deprecated. The acceptance versions also run locally, and because the snapshot is saved and reloaded between steps they cover incremental sync across runs, which the single-process tests did not.Tests
New tests pass locally (5 runs). Cloud run via CI.
This pull request and its description were written by Isaac.