Repository navigation
acc: record config edge cases for variables, YAML merge keys and diagnostic locations - #7029
Merged
Merged
Conversation
…nostic locations Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: cd981bc
Top 5 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
commented
Oct 14, 2026
| @@ -0,0 +1 @@ | |||
| Badness = "With <<: [*a, *b] the later anchor wins; the YAML merge key spec gives precedence to the earlier one." | |||
Contributor
Author
There was a problem hiding this comment.
@pietern I wonder if we should change this.
| Library | Version | merged.x |
Follows spec |
|---|---|---|---|
go.yaml.in/yaml/v3 (used by the CLI) |
v3.0.5 | from-a |
yes |
gopkg.in/yaml.v3 |
v3.0.1 | from-a |
yes |
gopkg.in/yaml.v2 |
v2.4.0 | from-a |
yes |
sigs.k8s.io/yaml (wraps yaml.v2) |
v1.6.0 | from-a |
yes |
github.com/goccy/go-yaml |
v1.19.2 | from-b |
no |
PyYAML (yaml.safe_load) |
latest via uv |
from-a |
yes |
| yaml-online-parser | — | from-a |
yes |
Databricks CLI on main (libs/dyn/yamlloader) |
— | from-b |
no |
…ript Co-authored-by: Isaac <no-reply@databricks.com>
shreyas-goenka
approved these changes
Oct 14, 2026
denik
enabled auto-merge
October 14, 2026 12:58
…recorded Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New acceptance tests that record current behaviour of config edge cases, so the libs/dyn removal (#6954) can't change it silently:
<<: [*a, *b]precedence; full definitions through a merge key; complex values fromvariable-overrides.jsonwith relative paths.compute_iddeprecation locations; errors on target-overridden values point at the effective setting (engine,trigger_pause_status,name_prefix); required-field errors for dashboard keys with special characters;development: ${...}deprecation warning.sourcein a git-backed job;bundle runresolvingrun_job_task.job_id: ${resources.jobs.x.id}.Some recorded behaviour looks wrong on main (merge-key precedence is the reverse of the YAML spec; relative paths in
variable-overrides.jsonresolve differently for task files and libraries; targetcompute_idis reported for unselected targets). The tests record it as is; fixes are separate.Tests
New tests only, no code changes.
This pull request and its description were written by Isaac.