Repository navigation
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
…elpers Co-authored-by: Isaac <no-reply@databricks.com>
…ath at preflight Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 29539ed
Top 3 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (merge in this order):
Changes
This PR is a refactor in
libs/localenv. It does not change behavior. It adds two seams that #7018 uses for uv workspace members:PostProvisionandValidatetake the project folder and the venv folder. uv and the validate probe still run in the project folder. Preflight sets the venv folder; for every project it is still.venv.pyproject.tomlbackup, write, and dry-run diff are per-file helpers (writePyproject,pyprojectDiff, and backup helpers that take a folder). This lets Support uv workspace members in environments setup-local #7018 write a second file, the workspace rootpyproject.toml.Why
In a uv workspace member,
uv syncputs the venv at the workspace root, and uv reads the constraint pins only from the rootpyproject.toml(databricks/databricks-vscode#2157). The pipeline used one fixed venv path and onepyproject.toml. This PR makes both locations parameters, so #7018 can change them for a member without a mixed refactor-and-feature diff.Tests
This pull request and its description were written by Isaac.