Repository navigation
Conversation
…y pipelines The backend makes a gateway pipeline continuous and copies the gateway storage catalog/schema into the top-level catalog/schema. When the config declares none of them, every deploy planned an update that unset them; the API rejects unsetting schema, so the deploy failed. Add a cloud-capable acceptance test with testserver support for connections and gateway pipeline defaults. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 4629eeb
Top 1 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
For an ingestion gateway pipeline the backend sets
continuous: trueand copiesgateway_storage_catalog/schemainto the top-levelcatalog/schema. If the bundle declares none of them, every deploy planned an update unsetting them. The API rejects that (Cannot unset 'schema' field), so the deploy failed.Fix:
ignore_remote_additionswithwhen_set: gateway_definitionfor pipelines. Fields the config does declare still diff.Also adds
connectionsand gateway defaults to the testserver, and an acceptance test (Cloud = true, not GCP) that passes on aws-prod-ucws and azure-prod-ucws. Without the fix it plans an update.Related: OSS-34
This pull request and its description were written by Isaac.