Repository navigation
acc: keep $UNIQUE_NAME out of replace_ids.py/read_id.py placeholder names - #7015
Merged
Merged
Conversation
…ames Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 4d1877f
Top 3 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
October 12, 2026 11:27
denik
enabled auto-merge
October 12, 2026 11:37
janniklasrose
approved these changes
Oct 12, 2026
Collaborator
Integration test reportCommit: 846e2c7
8 interesting tests: 8 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
replace_ids.pyandread_id.pysubstitute$UNIQUE_NAMEin the resource key before building the placeholder name, soproject_name_${UNIQUE_NAME}_etlbecomes[PROJECT_NAME_UNIQUE_NAME_ETL_ID].default-python/integration_classicnow usesreplace_ids.pyinstead of the/jobs/\d+workaround repls added in #6975.Why
The placeholder name is upper-cased, so the unique name inside it escaped the case-sensitive
[UNIQUE_NAME]replacement and the golden changed on every run.Tests
Acceptance tests for templates, permissions, deployment, dms, migrate pass locally.
This pull request and its description were written by Isaac.