Repository navigation
Conversation
Add libs/retry with the retry logic previously private to bundle/direct and a filer wrapper that retries overwriting writes. Use it for synced files, libraries, state and metadata uploads. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: dfbb482
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Overwriting writes to the workspace (synced files, libraries, state, metadata) are now retried up to twice on 5xx/408 errors the SDK doesn't already retry, same as
bundle/direct. The retry logic moved tolibs/retry, plus afiler.Filerwrapper that only retriesOverwriteIfExistswrites.Why
A single 504 on a file upload failed the whole deploy, while the direct engine tolerates the same error on resource calls.
Tests
Unit tests in
libs/retry, acceptance testbundle/deploy/files/upload-504.This pull request and its description were written by Isaac.