Repository navigation
Conversation
Collaborator
Integration test reportCommit: 6445c48
Top 5 slowest tests (at least 2 minutes):
|
When migrating Terraform state to the direct engine, reconcileIDFields looks up ID field values from the Terraform state to detect user-initiated renames/recreates not yet deployed. For secret scopes, the direct state field is `scope` but Terraform stores it as `name`. The lookup was using the unmapped DABs field name and failing silently, so pending renames were treated as normalization instead of being flagged for recreation. Add mapping: secret_scopes.scope <-> Terraform secret_scopes.name Fix: add the field rename mapping in terraform_dabs_map so LookupTFField can find the correct Terraform attribute name. Also add acceptance test to verify the fix works. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…nslation" This reverts commit 78d4918.
When migrating Terraform state to the direct engine, reconcileIDFields looks up ID field values from the Terraform state to detect user-initiated renames/recreates not yet deployed. For secret scopes, the direct state field is `scope` but Terraform stores it as `name`. The lookup was using the DABs field name and failing silently, so pending renames were treated as normalization instead of being flagged for recreation. Fix: add a fallback lookup in reconcileIDFields specifically for secret_scopes that translates the direct state field name to the Terraform attribute name. This keeps the fix localized to the migration context and does not affect field name translation for references or other parts of the system. Co-authored-by: Isaac <no-reply@databricks.com>
Look up the Terraform attribute through a small state-field table before the lookup rather than retrying with "name" after a failure, so there is one code path and the mapping is visible. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/tf-migrate-secret-scope-rename
branch
from
October 12, 2026 10:53
5d84be9 to
6445c48
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Terraform state is migrated to the direct engine, a secret scope renamed in config since the last Terraform deploy kept its old name: the id-field reconciler looked up the direct state field
scopein the Terraform attributes, where it is calledname, and silently skipped it. The migrated state then recorded the new name as deployed and the rename was never applied. The reconciler now maps that field explicitly, so the rename is surfaced as a recreate. Addsbundle/migrate/auto/secret-scope-rename.This pull request and its description were written by Isaac.