Repository navigation
acc: download old CLI versions in parallel - #6943
Merged
Merged
Conversation
The acceptance harness downloads three released CLIs (0.293.0, 1.8.0, 1.16.1) one after another. Start them concurrently right after the build dir is known so they overlap with the terraform/wheel/CLI builds, and wait for them where the env vars are set. The download helpers now return errors instead of calling require, since t.FailNow must only be called from the test goroutine. DownloadCLI stays as a thin require wrapper for the -useversion path, which waits for the background downloads first so the same version is never downloaded twice at once. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: dca7b75
Top 6 slowest tests (at least 2 minutes):
|
denik
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
errgroup. The downloads start as soon as the build dir is known, so they overlap with the terraform, wheel, and CLI builds. The harness waits for them whereCLI_293/CLI_1_8/CLI_1_16_1are set.downloadCLI,downloadToFile, andextractFileFromZipnow return errors instead of callingrequire, becauset.FailNowmust only be called from the test goroutine.DownloadCLI(t, ...)stays as a thinrequirewrapper for the-useversionpath.-useversionpath waits for the background downloads before it starts its own, so the same version never gets downloaded twice at once (e.g.-useversion 1.8.0).Why
On a cold cache (fresh worktree or CI), the three downloads ran one after another and blocked test startup.
Tests
go test -count=1 ./acceptance -run 'TestAccept/selftest/basic$'. Before: 12.0s / 8.5s. After: 4.8s / 4.2s.bundle/hashing/old-cli-on-new-state,bundle/state/feature_flags/accept_old,bundle/invariant/continue_293, andselftest/basicpass.-useversion 1.8.0with that version's dir removed passes.This pull request and its description were written by Isaac.