Repository navigation
Conversation
The v0.91.3 template sync failed with ERR_PNPM_MISSING_TIME. With minimumReleaseAge set explicitly, pnpm runs in strict mode, and pnpm 11.0.8 rethrows on abbreviated npm metadata (no per-version time) instead of fetching full metadata. Fixed in pnpm 11.1.2 (pnpm/pnpm#11619, pnpm/pnpm#11622). The sync now runs pnpm@11.1.2 through npx for the template install only, with pm-on-fail=ignore so it doesn't switch to the template's packageManager pin. The template keeps pnpm@11.0.8, which the Apps runtime bundles; 11.1.2 writes the same lockfile and 11.0.8 installs it with --frozen-lockfile. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Pawel Kosiec <pawel.kosiec@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Pawel Kosiec <pawel.kosiec@databricks.com>
Contributor
🤖 AppKit PR bot🔬 Run evalsStart an eval for this PR from the evals-monitor app: Go to Evals Monitor → 📦 Try this PR's app templateScaffolds a new app from this PR's SDK build. Run it in any folder (requires the GitHub CLI — gh run download 42875734935 -R databricks/appkit -n appkit-template-0.91.3-pr.44706b6-pkosiec-template-sync-pnpm-11-1-2-728 -D appkit-pr-728 \
&& unzip -o "appkit-pr-728/appkit-template-0.91.3-pr.44706b6-pkosiec-template-sync-pnpm-11-1-2-728.zip" -d "appkit-pr-728" \
&& databricks apps init --template "appkit-pr-728"The template pins |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.91.3 release failed in the template sync step:
publish-template-tag.tssetsminimumReleaseAge(#726), which puts pnpm in strict mode. Public npm serves abbreviated metadata without per-versiontime. pnpm 11.0.8 then throws instead of fetching full metadata. The bug is pnpm/pnpm#11619, fixed in pnpm/pnpm#11622 and released in pnpm 11.1.2.Changes
npx --yes pnpm@11.1.2for the template'spnpm install, plus the preflight.pnpm_config_pm_on_fail=ignorestops pnpm from switching to the template'spackageManagerpin.pnpm@11.0.8, which is the version the Apps runtime bundles. The rest of the repo stays on 11.0.8 too.Why only the template step
This is the only place that resolves with
minimumReleaseAge. Repo installs and CI use--frozen-lockfile, and the PR template job resolves through a registry that returns full metadata.Testing
Ran against a local registry proxy that strips
timefrom abbreviated metadata, the way public npm does. The internal npm proxy always returns full metadata, which is why this passed before.publish-template-tag.ts 0.91.3with pnpm 11.1.2 passes: install, commit, tag, push (to a local bare repo).ERR_PNPM_MISSING_TIME, matching the release.install --frozen-lockfileaccepts it.This pull request and its description were written by Isaac.