[PLUGIN-1787] Ignore 409 Conflict during retry of bucket creation in BigQuery source plugin - #1624
Open
vishwasvaidya-cloudsufi wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the bucket creation logic in BigQuerySourceUtils by extracting it into a reusable private helper method createBucket. This helper centralizes the handling of StorageException (specifically 409 conflicts) and safely handles potential null values for the dataset ID. Additionally, comprehensive unit tests have been added in BigQuerySourceUtilsTest to cover various success and failure scenarios during bucket creation. I have no feedback to provide as the changes are well-structured and properly tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PLUGIN-1787 / b/539473185 where BigQuery Source intermittently fails with
409 Conflict: Your previous request to create the named bucket succeeded and you already own itwhen the GCS client retries temporary staging bucket creation after transient network timeouts.Changes
BigQuerySourceUtils.javainto a sharedcreateBuckethelper for both auto-generated and user-configured buckets.StorageExceptionand ignored409 Conflictso the pipeline proceeds normally when the bucket already exists.Testing
BigQuerySourceUtilsTestfollowing Google Unit Testing Best Practices (AAA pattern,methodName_stateUnderTest_expectedBehavior, andAssert.assertThrows).getOrCreateBucket_nullBucketConflict409_returnsBucketAndEnablesDelete: Verifies 409 retry response returns the bucket and keeps delete enabled.getOrCreateBucket_nullBucketNon409Error_throwsProgramFailureException: Verifies non-409 exceptions are properly propagated.bq-409-conflict-resolution(completed successfully).