ENH: Adding tests for tril and triu#442
Draft
prady0t wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
prady0t
changed the title
tril and triu
prady0t
commented
Jul 13, 2026
Comment on lines
+395
to
+405
| def _triangular_expected(x, *, k, upper): | ||
| expected = xp.zeros_like(x) | ||
| n, m = x.shape[-2:] | ||
| for idx in sh.ndindex(x.shape[:-2]): | ||
| for i in range(n): | ||
| for j in range(m): | ||
| keep = j <= i + k if not upper else j >= i + k | ||
| if keep: | ||
| expected[idx + (i, j)] = x[idx + (i, j)] | ||
| return expected | ||
|
|
Author
There was a problem hiding this comment.
Review from Evgeni:
This is nice but fails on e.g. jax.numpy. Maybe reuse the value testing pattern from test_eye instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #441 (That PR has been split and tests for tril and triu are added here)
Towards: #439