-
Notifications
You must be signed in to change notification settings - Fork 32
ENH: add mparray backend
#963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -662,6 +662,7 @@ def test_basic(self, xp: ArrayNamespace): | |
| atol=1e-11, | ||
| ) | ||
|
|
||
| @pytest.mark.skip_xp_backend(Backend.MPARRAY, reason="negative zero not supported") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is just a fundamental limitation of |
||
| def test_real(self, xp: ArrayNamespace): | ||
| x = xp.asarray([0.0, -0.0, 1.0, -1.0]) | ||
| expected = xp.asarray([0.0, xp.pi, 0.0, xp.pi], dtype=x.dtype) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,6 +27,7 @@ | |
| Backend.TORCH_GPU, reason="device->host copy" | ||
| ), | ||
| pytest.mark.skip_xp_backend(Backend.SPARSE, reason="densification"), | ||
| pytest.mark.skip_xp_backend(Backend.MPARRAY, reason="precision loss"), | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure how
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's open an issue on the |
||
| ], | ||
| ), | ||
| ], | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -362,6 +362,7 @@ def test_lazy_xp_function_deprecated_static_argnames(): | |
|
|
||
|
|
||
| @pytest.mark.skip_xp_backend(Backend.TORCH_GPU, reason="device->host copy") | ||
| @pytest.mark.skip_xp_backend(Backend.MPARRAY, reason="mparray lacks __array_ufunc__") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we want compiled ufuncs to work on these if they don't preserve the precision; it's probably better to fail. (However,
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, that seems fine to me |
||
| @pytest.mark.filterwarnings("ignore:__array_wrap__:DeprecationWarning") # PyTorch | ||
| def test_lazy_xp_function_cython_ufuncs(xp: ArrayNamespace, library: Backend): | ||
| pytest.importorskip("scipy") | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.