Avoid external IP lookup for inproc addresses - #9356
Open
mmaxjr wants to merge 1 commit into
Open
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 40 files ± 0 40 suites ±0 14h 37m 40s ⏱️ + 19m 58s For more details on these failures, see this check. Results for commit a4b5b64. ± Comparison against base commit dc182bd. ♻️ This comment has been updated with latest results. |
mmaxjr
force-pushed
the
fix-localcluster-offline-warning
branch
from
August 30, 2026 13:57
25eb507 to
a4b5b64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8559.
This changes the inproc communication manager to use the loopback address as its local process identifier instead of calling get_ip(), which may try to discover a route to 8.8.8.8 and warn on offline machines. Since inproc addresses are only valid within the current process, no external IP discovery is needed.
Tests: