Repository navigation
feat(navigation-bar): circle buttons from tokens, 74pt bar - #21
Merged
Merged
Conversation
Back, close and plus are now a vector glyph centred in a code-drawn 34pt circle with a 1.5pt border, coloured by the toolbarRoundContent and toolbarRoundBorder tokens so both follow light/dark mode. The glyphs and the info icon are the design system's SVGs instead of baked PNGs. The bar is 74pt tall, and each button's touch area is 44pt tall and hugs the element's width, matching the design. BottomSheet's header title uses subheadMedium (15pt Medium) like the design's nav label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
romchornyi
approved these changes
Oct 15, 2026
romchornyi
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Approving.
I checked:
- The branch builds for the iOS Simulator in Debug, previews included. CI here only checks the PR title, so I built it locally.
- Nothing needs more than iOS 14:
Circle().strokeBorder,.overlayand a@ViewBuilderswitch are all fine there. - dashwallet-ios
developusesNavigationBarElementonly through.button(action:)and never touches.icondirectly. Droppingresizable()from.icontherefore doesn't affect the app.
Non-blocking notes:
- Tap target. The buttons go from 44×44 to 34×44, which is narrower than the 44pt HIG minimum. If this matches the design's
LeadingTouchAreaon purpose, fine. It's worth confirming with design. - Height change. The bar and the
BottomSheetheader grow by 10pt on every screen, and self-sizing sheets grow with them. When we bump DashUIKit in the app, a quick pass over the sheets in dark mode would be good, since only light mode was checked here. - RTL.
navigationbar-backisn't mirrored for right-to-left languages. That was already the case before this PR, so it's not a regression. It could be a follow-up.
ross-dash
added a commit
to dashpay/dashwallet-ios
that referenced
this pull request
Oct 16, 2026
…ocal copy Every SwiftUI screen that still drew its top bar from the app's own NavigationBar copy, the NavBarBack helper, or a hand-built chevron/xmark header now uses DashUIKit.NavigationBar with its back/close elements: Payments landing, Specify amount, Send steps, Buy & Sell portal, Notifications, Claim invitation, Merchant list, Explore menu, Username Marketplace, DashSpend pay/terms/auth. Connections, the Dash DEX portal and Coinbase Transfer already used DashUIKit's bar but filled it with the local back element; they now use DashUIKit's. With no callers left, the local NavigationBar, NavigationBarElement and NavBarBack/NavBarBackPlus/NavBarClose helpers and their navigationbar-* images are removed. Bar titles that were 14/17pt semibold use subheadMedium like the design's nav label. Bumps DashUIKit to 2b15ef7 (dashpay/DashUIKit#21: circle buttons from tokens, 74pt bar), which these screens and the More-tab ones pick up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 of 5 tasks
romchornyi
pushed a commit
to dashpay/dashwallet-ios
that referenced
this pull request
Oct 16, 2026
* feat(menu): move More-tab nav bars to DashUIKit NavigationBar The More tab's SwiftUI pages drew their top bar four different ways: the NavBarBack/NavBarBackPlus helpers, the app's own NavigationBar copy, and hand-built chevron rows. They now all use DashUIKit.NavigationBar with its back/plus elements, so they pick up the design-system bar and buttons. Settings, Security, Governance, Sync Info, Tools, Local Currency, Devnet settings, the recovery-phrase wallet chooser, About, Wallets, Wallet accounts, Wallet account detail, Identities (list, keys, detail), Derivation path keys and the Core/Platform/Shielded/DashPay sync pages. The sync pages padded their whole container, bar included, so the side padding moves onto the title and scroll content to keep the bar's own 20pt inset. Wallet accounts' bar title uses subheadMedium like the design's nav label. Page content is otherwise unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(ui): move remaining SwiftUI nav bars to DashUIKit and drop the local copy Every SwiftUI screen that still drew its top bar from the app's own NavigationBar copy, the NavBarBack helper, or a hand-built chevron/xmark header now uses DashUIKit.NavigationBar with its back/close elements: Payments landing, Specify amount, Send steps, Buy & Sell portal, Notifications, Claim invitation, Merchant list, Explore menu, Username Marketplace, DashSpend pay/terms/auth. Connections, the Dash DEX portal and Coinbase Transfer already used DashUIKit's bar but filled it with the local back element; they now use DashUIKit's. With no callers left, the local NavigationBar, NavigationBarElement and NavBarBack/NavBarBackPlus/NavBarClose helpers and their navigationbar-* images are removed. Bar titles that were 14/17pt semibold use subheadMedium like the design's nav label. Bumps DashUIKit to 2b15ef7 (dashpay/DashUIKit#21: circle buttons from tokens, 74pt bar), which these screens and the More-tab ones pick up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Updates
NavigationBarto the current design (Design system – iOS → Navigation bar, Figma nodes1839:112base and1839:254elements). The back/close/plus buttons were single PNGs with the circle baked in, so the ring couldn't follow the light/darktoolbar/RoundBorder/toolbar/RoundContentvariables, and the bar was 64pt instead of 74pt.What was done?
.back,.closeand.plusnow draw a 34pt circle with a 1.5ptColor.dash.toolbarRoundBorderstroke, with the glyph centred inside and tintedColor.dash.toolbarRoundContent. Both tokens already existed with light/dark values.navigationbar-back/close/plus/info) are now the design system's SVGs (preserved vectors) instead of @1x/@2x/@3x PNGs. The glyphs use template rendering, and info keeps its own colours.BottomSheetheader, which usesNavigationBar.LeadingTouchArea. It was 44×44, which put the circle 5pt in from the bar's 20pt edge padding.BottomSheet's header title uses.subheadMedium(15pt Medium, 20pt line height) to match the design's nav label. It used.calloutMedium(16pt Semibold).docs/navigation-and-containers.mdis updated, and so is a doc comment inBottomSheetthat referred to the 64pt height.How Has This Been Tested?
xcodebuild -scheme DashUIKitfor the iOS Simulator (Xcode 27).dashpayapp, on an iPhone 18 Pro simulator (iOS 27) with this branch overriding the package: the Home and Send screens, the transaction filter sheet and the block-explorer sheet, in light mode. Dark-mode colours come from the existing tokens.#Previews inNavigationBar.swiftandBottomSheet.swift.Breaking Changes
No API changes:
NavigationBar,NavigationBarElement.iconand.button(action:)keep their signatures.Visual and layout changes for consumers:
Checklist:
🤖 Generated with Claude Code