Capture sharpen improvements by jenshannoschwalm · Pull Request #22334 · darktable-org/darktable

jenshannoschwalm · 2026-09-19T08:38:40Z

Summary: Various fixes for capture sharpening, algorithms stayed identical, current edits are unmodified.

As we always calculate the capture sharpen radius in full pipe we have complete image data (after introdution of demosaicscale) and thus can leave out some checks & reports.
We now correctly snap the area used for capture radius calculation matching the sensor type, not ensuring this made lead to silently incorrect data.
The default capture contrast sensitivity has been further tuned for 14bit raw images.
Substantial work on pixelpipe and the module's gui_data interference for safety and in a few cases also for UI performance.
I have read CONTRIBUTING.md and the coding style.
I don't have merged master into the topic branch.
The pull request is one logical change, and every commit compiles on its own.
I ran the relevant tests: unit tests, src/tests/integration/ where the pixelpipe is touched, or darktable-cli as a headless smoke test.
New user-visible strings use _(), new preferences are registered in data/darktableconfig.xml.in.
A RELEASE_NOTES.md entry was added (only needed if fixing an issue in a release). Do not reference GitHub issues.

Copilot

Copilot review overview

🟡 Changes recommended

Auto-tuning regresses headless processing and cropped HQ inputs, while calculation failures can overwrite valid parameters.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 4 · 3

Open (7)

Restore headless auto-radius calculation for capture sharpening · New
Preserve capture radius when allocation fails · New
Restore headless OpenCL auto-radius calculation · New
Preserve ROI offsets when bypassing demosaic scaling · New
Fix typo and plural agreement in comment · New
Use the grammatically correct verb form · New
Fix malformed punctuation in user-facing error · New

What changed in this PR

Improves capture-sharpen auto-tuning, sensor-area selection, failure reporting, and GUI synchronization.

Changes:

Tunes defaults and 14-bit RAW sensitivity.
Refactors CPU/OpenCL radius calculation and GUI updates.
Adds release notes.

File	Description
`src/iop/demosaicing/capture.c`	Updates radius calculation and error handling.
`src/iop/demosaic.c`	Refactors auto-tuning and GUI synchronization.
`RELEASE_NOTES.md`	Documents user-visible fixes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🟡 Changes recommended

The asynchronous autotuning handoff can commit stale values, and an OpenCL fallback message incorrectly implies final failure.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Prevent stale asynchronous autotune results from overwriting requests · New
Report CPU fallback instead of final sharpening failure · New

Resolved since last review (7)

Preserve ROI offsets when bypassing demosaic scaling
Restore headless OpenCL auto-radius calculation
Preserve capture radius when allocation fails
Restore headless auto-radius calculation for capture sharpening
Fix malformed punctuation in user-facing error
Use the grammatically correct verb form
Fix typo and plural agreement in comment

Copilot

Copilot review overview

🟡 Changes recommended

Headless processing can access absent GUI state, while concurrent pipes can publish or persist incorrect autotuning results.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Reset autotune state when switching images · New
Remove user-facing logs for expected autotune fallbacks · New

Resolved since last review (2)

Prevent stale asynchronous autotune results from overwriting requests
Report CPU fallback instead of final sharpening failure

Copilot

Copilot review overview

🟡 Changes recommended

Autotune synchronization remains race-prone, and OpenCL failures can publish an invalid radius or misleading error.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2

Open (2)

Restrict GUI autotuning to the full pipe · New
Initialize OpenCL radius fallback to 0.5f · New

Resolved since last review (2)

Reset autotune state when switching images
Remove user-facing logs for expected autotune fallbacks

Copilot

Copilot review overview

🟡 Changes recommended

Headless autotuning regressions and request/result synchronization races remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 1 · 1

Open (3)

Allow headless autotuning for edited images with zero radius · New
Preserve pending autotune requests until results are ready · New
Fix grammatical errors in the fallback explanation · New

Resolved since last review (2)

Initialize OpenCL radius fallback to 0.5f
Restrict GUI autotuning to the full pipe

Copilot

Copilot review overview

🟡 Changes recommended

A stale autotune request can carry across image switches and modify the next image.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

Use singular noun after the article · New

Resolved since last review (3)

Allow headless autotuning for edited images with zero radius
Preserve pending autotune requests until results are ready
Fix grammatical errors in the fallback explanation

- As we always calculate the capture sharpen radius in full pipe we have complete image data (after introdution of demosaicscale) and thus can leave out some checks & reports. - We now correctly snap the area used for capture radius calculation matching the sensor type, not ensuring this made lead to silently incorrect data. - The default capture contrast sensitivity has been further tuned for 14bit raw images. - Substantial work on pixelpipe and the module's gui_data interference for safety and in a few cases also for UI performance. - Fixed exports after darkroom editing falling back to auto-calculation of capture radius with a defined radius of zero

jenshannoschwalm · 2026-09-20T05:58:12Z

@TurboGit - now ready to go.

TurboGit

Thanks!

jenshannoschwalm requested a balanced review from Copilot September 19, 2026 08:38

Copilot started reviewing on behalf of jenshannoschwalm September 19, 2026 08:39 View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

TurboGit added this to the 5.8 milestone Sep 19, 2026

TurboGit added feature: enhancement current features to improve scope: image processing correcting pixels labels Sep 19, 2026

jenshannoschwalm requested a balanced review from Copilot September 19, 2026 10:04

Copilot started reviewing on behalf of jenshannoschwalm September 19, 2026 10:05 View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

Comment thread src/iop/demosaic.c Outdated

Comment thread src/iop/demosaicing/capture.c

jenshannoschwalm force-pushed the better_auto_capture branch from a6d543d to cb377b6 Compare September 19, 2026 10:45

jenshannoschwalm requested a balanced review from Copilot September 19, 2026 10:45

Copilot started reviewing on behalf of jenshannoschwalm September 19, 2026 10:46 View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

Comment thread src/iop/demosaic.c

Comment thread src/iop/demosaicing/capture.c Outdated

jenshannoschwalm force-pushed the better_auto_capture branch from cb377b6 to 616c4aa Compare September 19, 2026 16:24

jenshannoschwalm requested a balanced review from Copilot September 19, 2026 16:25

jenshannoschwalm added the bugfix pull request fixing a bug label Sep 19, 2026

Copilot started reviewing on behalf of jenshannoschwalm September 19, 2026 16:25 View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

Comment thread src/iop/demosaic.c

Comment thread src/iop/demosaicing/capture.c Outdated

jenshannoschwalm force-pushed the better_auto_capture branch from 616c4aa to f3b4597 Compare September 19, 2026 16:39

jenshannoschwalm requested a balanced review from Copilot September 19, 2026 16:39

Copilot started reviewing on behalf of jenshannoschwalm September 19, 2026 16:40 View session

jenshannoschwalm added the Abstract provided Includes a 5-liner human written abstract label Sep 19, 2026

Copilot AI reviewed Sep 19, 2026

View reviewed changes

Comment thread src/iop/demosaic.c

Comment thread src/iop/demosaic.c

Comment thread src/iop/demosaicing/capture.c Outdated

jenshannoschwalm force-pushed the better_auto_capture branch from f3b4597 to d43eeb7 Compare September 20, 2026 05:22

jenshannoschwalm requested a balanced review from Copilot September 20, 2026 05:28

Copilot started reviewing on behalf of jenshannoschwalm September 20, 2026 05:29 View session

Copilot AI reviewed Sep 20, 2026

View reviewed changes

Comment thread src/iop/demosaicing/capture.c Outdated

jenshannoschwalm force-pushed the better_auto_capture branch from d43eeb7 to e5b72ed Compare September 20, 2026 05:48

TurboGit approved these changes Sep 20, 2026

View reviewed changes

TurboGit merged commit 31b2dac into darktable-org:master Sep 20, 2026
6 checks passed

jenshannoschwalm deleted the better_auto_capture branch September 20, 2026 09:10

Conversation

jenshannoschwalm commented Sep 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

jenshannoschwalm commented Sep 20, 2026

Uh oh!

TurboGit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants