Skip to content

ashift: don't drop the deferred autocrop on an early preview signal #22332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TurboGit merged 3 commits into from
Sep 19, 2026
Merged

ashift: don't drop the deferred autocrop on an early preview signal #22332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00af501
ashift: don't drop the deferred autocrop on an early preview signal
kofa73 Sep 19, 2026
581c83e
RELEASE_NOTES.md: ashift autocrop lost on first rotation
kofa73 Sep 19, 2026
5e98e3e
ashift: take gui_lock for the deferred crop's buffer size check
kofa73 Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,10 @@ changes (where available).

- Fixed a crash on using tag floating window after editing metadata.

- Fixed rotate and perspective sometimes not applying its automatic
crop when the rotation was changed (e.g. with a shortcut) before the
module had been enabled, leaving empty corners in the image.

## Lua

### API Version
Expand Down
11 changes: 11 additions & 0 deletions src/iop/ashift.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5561,6 +5561,17 @@ static void _event_process_after_preview_callback(gpointer instance, dt_iop_modu
switch(jobcode)
{
case ASHIFT_JOBCODE_DO_CROP:
// the signal can come from a preview run that started before the
// module was enabled and so never filled g->buf; do_crop() would
// return without cropping, so keep the request for the next run
dt_iop_gui_enter_critical_section(self);
const gboolean buf_empty = g->buf_width == 0 || g->buf_height == 0;
dt_iop_gui_leave_critical_section(self);
if(buf_empty)
{
g->jobcode = ASHIFT_JOBCODE_DO_CROP;
break;
}
do_crop(self, p);
_commit_crop_box(p, g);
// save all that
Expand Down
Loading