RFC: add scene-referred grain module - #22311
Draft
piratenpanda wants to merge 4 commits into
Draft
piratenpanda wants to merge 4 commits into
piratenpanda wants to merge 4 commits into
Conversation
piratenpanda
marked this pull request as draft
September 17, 2026 04:32
piratenpanda
force-pushed
the
film_grain_scene_referred
branch
from
September 17, 2026 13:55
4e9c40e to
227b00e
Compare
piratenpanda
force-pushed
the
film_grain_scene_referred
branch
from
September 18, 2026 17:58
3eb200b to
d9939d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current grain module is still display-referred and does not offer a film-like grain method. Now that spektrafilm is in master, we can reuse the grain code to offer film-like grain for other tone-mappers as well.
Checklist
coding style.
own.
src/tests/integration/where thepixelpipe is touched, or
darktable-clias a headless smoke test._(), new preferences are registered indata/darktableconfig.xml.in.RELEASE_NOTES.mdentry was added.AI assistance
Co-created with Claude Opus 5