Conversation
g_main_context_invoke() runs its callback in the calling thread whenever it can acquire the context. During dt_init() the gui thread holds the context only inside dt_gui_process_events(), so Lua and job threads built and reparented widgets in parallel with the main window being assembled, crashing at random during startup. Acquire the context after gtk_init() and release it before dt_control_shutdown() joins the worker threads. Speculatively fixes darktable-org#21996
1 task
da-phil
marked this pull request as draft
September 4, 2026 10:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g_main_context_invoke() runs its callback in the calling thread whenever it can acquire the context. During dt_init() the gui thread holds the context only inside dt_gui_process_events(), so Lua and job threads built and reparented widgets in parallel with the main window being assembled, crashing at random during startup.
Acquire the context after gtk_init() and release it before dt_control_shutdown() joins the worker threads.
Speculatively fixes #21996
AppImages for testing: https://github.com/da-phil/darktable/actions/runs/33894515106#artifacts
Disclaimer: this change was co-created with Claude.