Repository navigation
Conversation
deleteStateAsync() passes null as the etag to tryDeleteStateAsync(), whose $etag parameter is typed as non-nullable string, so any call to deleteState() fatals with: TypeError: tryDeleteStateAsync(): Argument dapr#3 ($etag) must be of type string, null given The implementation already handles an empty etag (no If-Match header is sent), so widen the parameter to string|null on both tryDeleteState and tryDeleteStateAsync (abstract + HTTP implementation) and add regression tests for deleting with and without an etag. Signed-off-by: Mark A. Hershberger <mah@nichework.com>
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
deleteStateAsync()callstryDeleteStateAsync($storeName, $key, null, ...)(delete without an etag), buttryDeleteStateAsync()declaresstring $etag(non-nullable), so everydeleteState()call fatals:The method body already handles an empty etag (it only sends the
If-Matchheader when!empty($etag)), so the fix is to widen$etagtostring|nullon bothtryDeleteStateandtryDeleteStateAsync(abstract declaration + HTTP implementation). Surfaced while building a PHP state-management quickstart for dapr/quickstarts.Issue reference
Fixes #153
Checklist
tests/DeleteStateTest.php(delete without etag sends noIf-Match; delete with etag sendsIf-Match)