Repository navigation
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
…ctivation Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
nelson-parente
left a comment
Contributor
There was a problem hiding this comment.
#1840 added the gRPC actor event stream after this branched. ActorEventDispatcher on master calls runtime.invoke, invokeReminder and invokeTimer without the activation id, so stream-hosted actors keep the stale object. Can you rebase and pass the id from request.getMetadata() there?
JoshVanL
requested changes
Oct 27, 2026
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
javier-aliaga
requested changes
Oct 28, 2026
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1876 +/- ##
============================================
+ Coverage 80.69% 80.94% +0.25%
- Complexity 2851 2922 +71
============================================
Files 275 276 +1
Lines 8459 8591 +132
Branches 911 930 +19
============================================
+ Hits 6826 6954 +128
+ Misses 1266 1265 -1
- Partials 367 372 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
javier-aliaga
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with the dapr/dapr change that sends
Dapr-Actor-Activation-Idon actor callbacks.After daprd is killed the app keeps its actor objects, and the new daprd never sends DELETE for them. The SDK reused the stale object, skipped onActivate and kept its in-memory fields.
IllegalStateExceptionActorRuntimeandDaprControllerget overloads with the id, old signatures still workNot covered: a save already in flight can still land late. Etags on actor state are a follow-up.