fix(packaging): ship wire-ci CI templates in the npm tarball - #115
Open
56phil wants to merge 1 commit into
Open
Conversation
.npmignore excluded docs/ wholesale, so the npm package dropped docs/templates/ci/github/*.yml — the exact files wire-ci's verify gate and self-test require. The templates exist in the repo but never reached installed users, so every wire-ci run emitted 'SKIP — no bundled template'. Un-ignore docs/templates/ (20K: the four CI templates + the AGENTS.md Reach template seed-conventions references at runtime) and extend test-install-helpers.js with a real npm pack --dry-run assertion that the templates are present in the tarball, so a future .npmignore edit cannot silently drop them again. Closes danielvm-git#113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.npmignoreexcludeddocs/wholesale, so the npm package droppeddocs/templates/ci/github/*.yml— the exact fileswire-ci's verify gate and self-test require. The templates exist in the repo but never reached installed users, so everywire-cirun emittedSKIP — no bundled templateandbash scripts/wire-ci.sh --self-testfailed against the package.Change
.npmignore:docs/→docs/*+!docs/templates/— ships the 20Kdocs/templates/(the four CI templates + theAGENTS.mdReach template thatseed-conventionsandverify-install.shreference at runtime) while still excluding the 1.3 MB of docs prose/images.scripts/test-install-helpers.js: extend the existing BUG-2026-08-07.npmignoreregression guard with a realnpm pack --dry-runassertion that all four CI templates anddocs/templates/AGENTS.mdare present in the tarball — a pattern check alone cannot model gitignore negation.Verification
bash scripts/wire-ci.sh --self-test→ PASS (was FAIL against the package).bash scripts/run-skill-verify.sh wire-ci→ 3 PASS, 0 FAIL (was 2 FAIL).npm pack --dry-runlists all fourdocs/templates/ci/github/*.ymlfiles.bash scripts/test-install-helpers.sh→ ALL PASS.Closes #113.