feat(contact): wire up the resume contact form - #39
Closed
danielheene wants to merge 1 commit into
Closed
Conversation
The ResumeContact block previously rendered only a title/caption with a commented-out mail link — no actual form existed. - Add ContactForm.client.tsx: name/email/message inputs plus a hidden honeypot field, driven by useActionState against a server action. - Add submitContactForm server action: validates input with zod, rejects silently on a filled honeypot, looks up the recipient email from GlobalUserSettings, and sends via the existing useSendAdapter through payload.sendEmail, with the submitter set as replyTo. Errors are logged server-side and reported to the client as a generic message so upstream details never leak. - Wire ContactForm into ResumeContactBlockClientRenderer in place of the commented-out button.
danielheene
marked this pull request as ready for review
August 16, 2026 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ResumeContactblock previously rendered only a title/caption with a commented-out mail link — there was no actual form. This wires up a working contact form.ContactForm.client.tsx: name/email/message inputs plus a hidden honeypot field, driven byuseActionStateagainst a new server action.submitContactFormserver action: validates input with zod, silently no-ops if the honeypot is filled, looks up the recipient address fromGlobalUserSettings, and sends the message via the existinguseSendAdapterthroughpayload.sendEmail, with the submitter set asreplyTo. Failures are logged server-side and reported to the client as a generic message so no upstream details leak.ContactFormintoResumeContactBlockClientRendererin place of the commented-out button.Test plan
pnpm vitest run— full suite (271 tests) passes, including 6 new tests covering: successful send, invalid email, empty message, honeypot short-circuit, missing recipient config, and send failure not leaking error details.biome check— clean on all new/changed files.tsc --noEmit— no new errors (pre-existing unrelatedPagePropscodegen errors only).🤖 Generated with Claude Code