Repository navigation
Index source locations once per compiler request - #683
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #682. Index source locations once per input file during a compiler request so rendering each declaration's comments no longer scans the whole file. Preserve the first matching location and the existing formatting of detached, leading, and trailing comments.
The 65 existing proto fixtures produce identical output before and after this change in both standard and Pydantic modes. A synthetic 1,500-field request with 6,001 source locations takes a median 0.29 seconds instead of 6.25 seconds through the complete generator, including Ruff. The 10-field case remains dominated by formatter startup (roughly 70 ms). Core tests: 191 passed; new regression tests also pass on Python 3.9.
This change was developed and independently reviewed with Codex. The full upstream suite was not run; validation used the core/compiler tests and all existing proto fixtures. Ruff 0.12.8 was available locally, rather than the project's pinned ~0.9.1.
Checklist