Skip to content

Add IZeroClampSeries and RoiResponseSeries to the neurodata type map; fix OptogeneticStimulusSite typo #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bendichter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add IZeroClampSeries and RoiResponseSeries to the neurodata type map; fix OptogeneticStimulusSite typo #1946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions dandi/metadata/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,12 @@ class Neurodatum(TypedDict):
"technique": "current clamp technique",
"approach": "electrophysiological approach",
},
"IZeroClampSeries": {
"module": "icephys",
"neurodata_type": "IZeroClampSeries",
"technique": "current clamp technique",
"approach": "electrophysiological approach",
},
"VoltageClampSeries": {
"module": "icephys",
"neurodata_type": "VoltageClampSeries",
Expand Down Expand Up @@ -885,6 +891,12 @@ class Neurodatum(TypedDict):
"technique": None,
"approach": "microscopy approach; cell population imaging",
},
"RoiResponseSeries": {
"module": "ophys",
"neurodata_type": "RoiResponseSeries",
"technique": None,
"approach": "microscopy approach; cell population imaging",
},
"Position": {
"module": "behavior",
"neurodata_type": "Position",
Expand Down Expand Up @@ -963,9 +975,9 @@ class Neurodatum(TypedDict):
"technique": "fourier analysis technique",
"approach": None,
},
"OptogeneticStimulusSIte": {
"OptogeneticStimulusSite": {
"module": "ogen",
"neurodata_type": "OptogeneticStimulusSIte",
"neurodata_type": "OptogeneticStimulusSite",
"technique": None,

@yarikoptic yarikoptic Oct 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in

@rly proposed

Suggested change
"technique": None,
"technique": "surgical technique",

I wonder if we should include this here, or just keep as is to the typo fix?

"approach": "optogenetic approach",
},
Expand Down
22 changes: 20 additions & 2 deletions dandi/tests/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,6 +1062,15 @@ def test_species_record_matching_methods() -> None:
"variableMeasured": ["CurrentClampStimulusSeries"],
},
),
pytest.param(
["IZeroClampSeries"],
{
"approach": ["electrophysiological approach"],
"measurementTechnique": ["current clamp technique"],
"variableMeasured": ["IZeroClampSeries"],
},
marks=pytest.mark.ai_generated,
),
(
["VoltageClampSeries"],
{
Expand Down Expand Up @@ -1110,6 +1119,15 @@ def test_species_record_matching_methods() -> None:
"variableMeasured": ["PlaneSegmentation"],
},
),
pytest.param(
["RoiResponseSeries"],
{
"approach": ["microscopy approach; cell population imaging"],
"measurementTechnique": None,
"variableMeasured": ["RoiResponseSeries"],
},
marks=pytest.mark.ai_generated,
),
(
["Position"],
{
Expand Down Expand Up @@ -1215,11 +1233,11 @@ def test_species_record_matching_methods() -> None:
},
),
(
["OptogeneticStimulusSIte"],
["OptogeneticStimulusSite"],
{
"approach": ["optogenetic approach"],
"measurementTechnique": None,
"variableMeasured": ["OptogeneticStimulusSIte"],
"variableMeasured": ["OptogeneticStimulusSite"],
},
),
(
Expand Down
Loading