Repository navigation
Drop pynwb < 3.1 compatibility code from pynwb_utils - #1939
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1939 +/- ##
=======================================
Coverage 78.40% 78.41%
=======================================
Files 92 92
Lines 14142 14130 -12
=======================================
- Hits 11088 11080 -8
+ Misses 3054 3050 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Note: code is technically covered by the |
CodyCBakerPhD
removed this pull request from stack #1940
September 27, 2026 20:17
CodyCBakerPhD
added this pull request to stack #1942
September 27, 2026 20:17
yarikoptic
approved these changes
Sep 28, 2026
Member
|
great , thanks! |
Member
|
I would have merged it but it seems part of the stack.... yet to learn the process ;-) |
yarikoptic
force-pushed
the
claude/pynwb-utils-drop-legacy-pynwb
branch
from
September 28, 2026 14:38
023745f to
dab93f5
Compare
Contributor
Author
Yeah stacks can go either way - if a long series of changes that are intended to go in all at once as 'some big feature' then start from top then go down For this I strongly recommend just starting from the bottom and working the way up, many of those are nearly-standalone improvements but still cleaner for the top to not deal with them all split apart |
Base automatically changed from
claude/validate-broken-symlink-path
to
master
September 30, 2026 00:59
yarikoptic
force-pushed
the
claude/pynwb-utils-drop-legacy-pynwb
branch
from
September 30, 2026 00:59
dab93f5 to
16cdedd
Compare
Contributor
Author
|
@yarikoptic This one is next, once CI is happy |
The declared floor is pynwb >= 3.1.0 (and nwbinspector >= 0.7.0 requires pynwb >= 3.1 anyway), which makes several version guards unreachable: - validate(): only the `pynwb.validate(path=...)` branch (pynwb >= 3.0) can run; the `paths=[...]` tuple-returning form (2.2 to 2.x) and the `io=` fallback for even older releases are gone. - copy_nwb_file(): `cache_spec` has been accepted by `export()` since pynwb 2.8.2, so pass it unconditionally. - _get_external_images(): `ExternalImage` exists in every supported pynwb, so import it at module level instead of guarding an ImportError. The now-unused `packaging.version.Version` import is removed as well. The NWB *schema* version checks (e.g. the < 2.1.0 error filter) are about the file being validated, not about pynwb, and are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HFhMPs6vF5zyeHDvPTvRcA
CodyCBakerPhD
force-pushed
the
claude/pynwb-utils-drop-legacy-pynwb
branch
from
October 6, 2026 18:01
16cdedd to
91aaca7
Compare
yarikoptic
approved these changes
Oct 6, 2026
CodyCBakerPhD
pushed a commit
that referenced
this pull request
Oct 6, 2026
…hamilton-ast647 The base was rebased onto master (with #1937 and #1939 squash-merged) and now uses fscacher >= 0.5.0's memoize_path(custom_fingerprint=...). Resolve accordingly: - Drop memoize_source and its tests: get_metadata, get_neurodata_types, nwb_has_external_links and _validate now use memoize_path(custom_fingerprint=readable_fingerprint). - Drop ExistingPath in favor of LinkAwarePath(lexists=True) from #1937. - Keep the streaming support (_validate reading from a Readable) and its test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet another split out of #1933 to clean up some dead code
The declared floor in the pyproject.toml is
pynwb >= 3.1.0(andnwbinspector >= 0.7.0requirespynwb >= 3.1anyway), which makes several version guards unreachable:pynwb.validate(path=...)branch (pynwb >= 3.0) can run; thepaths=[...]tuple-returning form (2.2 to 2.x) and theio=fallback for even older releases are gone.cache_spechas been accepted byexport()since pynwb 2.8.2, so pass it unconditionally.ExternalImageexists in every supported pynwb, so import it at module level instead of guarding an ImportError.The now-unused
packaging.version.Versionimport is removed as well. The NWB schema version checks (e.g. the < 2.1.0 error filter) are about the file being validated, not about pynwb, and are unchanged.Claude-Session: https://claude.ai/code/session_01HFhMPs6vF5zyeHDvPTvRcA