feat: add "Say thanks" action to received Award notification#6302
Open
capJavert wants to merge 1 commit into
Open
feat: add "Say thanks" action to received Award notification#6302capJavert wants to merge 1 commit into
capJavert wants to merge 1 commit into
Conversation
Adds an inline "Say thanks" button on the UserReceivedAward notification item, mirroring the "Follow back" action on UserFollow. Calls the new sayThanksForAward mutation and swaps to a disabled "Thanked" state on success. No affordance is added to ListAwardsModal. Also renders the resulting UserAwardThanked notification for the sender. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a lightweight, one-tap "Say thanks" action so a recipient of a Cores Award can acknowledge the sender directly from the notifications page — modeled on the existing "Follow back" action on the
UserFollownotification.Changes
NotificationSayThanksButtonrendered inline on theUserReceivedAwardnotification item only, mirroringNotificationFollowUserButton(placement,-ml-3.5/mt-3alignment, tertiary → primary state swap).sayThanksForAward(transactionId)GraphQL mutation and swaps to a disabled "Thanked" state on success. ACONFLICTresponse (already thanked elsewhere) resolves to the same "Thanked" state rather than an error toast.UserAwardThankednotification type in the shared notifications enum, theme, and category maps so the sender's acknowledgement renders correctly.Key decisions
ListAwardsModal— the single entry point is the notification item.thankedAt, so the button uses local state + the mutation's idempotency guard; the backend prevents any double-notify.Backend counterpart (mutation, notification worker,
thankedAtflag) ships in the daily-api PR.Closes ENG-1774
Created by Huginn 🐦⬛
Preview domain
https://eng-1774-feedback-feature-reques.preview.app.daily.dev