Repository navigation
feat(metrics): benchmark metrics and payment frequency from the shared blocks - #115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wires the shared
benchmarkblock (32 keys against SPY and QQQ) and replaces thedividendsblock with the eight-key version (paymentsPerYear,payFrequency). Yahoo mode: the benchmark tap wraps the dividends tap on the swing request (one request feeds swing, dividends and benchmark), plus one SPY and one QQQ chart per run throughrequestText(request gate, retries, timeout, browser User-Agent); skipped after the soft deadline, like the fund charts. README metrics list extended.Why
Plan
etf-benchmark-screeners-plan.md, stage 4: benchmark and payment-frequency metrics in every brand feed for the Stocks screener. Same wiring as SPDR PR 104.Checked locally (no CI)
benchmark-gates.sh check: ok install, test, test-env, build-updater, build-ui, diff-check, readme, scripts, log-tags, block, tc (53 lines, baseline 53)bun test: 42 pass, 0 fail; fake clock +50 and +548 days: 42 pass eachTest mock: the swing chart answer gets
adjclose(same numbers asclose) and serves SPY and QQQ too; chart requests asserted: AAA, BBB, CCC, QQQ, SPYReal run
TICKERS=DVY REQUEST_SLEEP=0 ./scripts/update-data.ts: vsSpy1y 6.78, beta1ySpy 0.25, payFrequency quarterly (4 payments), benchmarkAsOf 2026-11-13; all funds share one key list; data not committed