Repository navigation
feat(ui): one style for panels and controls - #114
Merged
Merged
Conversation
Panels, controls, tabs, checkboxes and the Clear dialog now use the shared style block (tokens, .ui-panel, .ui-btn, .ui-chip, .ui-check, .ui-input, .ui-badge, .ui-x, .ui-modal*); Filters and Sticky # are toggles; the toolbar is one wrapping row; the menu restyle is folded in. fix: init() runs after every top-level declaration, a reload with a saved selection no longer stops at "Cannot access ... before initialization" Gates (style-gates.sh iShares): ALL GATES PASSED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: one shared style for panels and controls (style block, tokens, component classes, Clear dialog on .ui-modal, Filters and Sticky # toggles, one wrapping toolbar row), the menu restyle folded in. Also fix: init() moved after every top-level declaration so a reload with a saved selection no longer throws 'Cannot access ... before initialization'.
Checked locally with style-gates.sh: ALL GATES PASSED iShares (install, test, build-updater, build-main, build, diff-check, tc, menu, brand, columns, categories, clear, security, pcheck, subcheck, style, reload). Pass counts: 46 passed, 0 failed, 44 passed, 0 failed, 19 passed, 0 failed, 19 passed, 0 failed, 20 passed, 0 failed, 79 passed, 0 failed, 20 passed, 0 failed,. Screenshots reviewed in both themes at 1500 and 390 px.