Repository navigation
fix(ui): keep the top panel one height at 1024 px, tidy the actions menu block - #112
Merged
Merged
Conversation
…enu block At 1024 px with every fund selected the selected tabs lose their counts and scrollbar and the title column fits its content, so the first panel stays one height. The actions menu block returns to the verbatim ui-std block. Ported by ui-std top-panel-tidy.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
lgandxlthe selected detail tabs (#selected-tabs-bar) drop their counts (<span class="lg:max-xl:hidden"> (N)</span>) and the bar hides its scrollbar ([scrollbar-width:none],[&::-webkit-scrollbar]:hidden; wheel, touch and keyboard focus still scroll it)lgandxlthe title column of the first panel is at least as wide as icon + title (lg:max-xl:grid-cols-[minmax(max-content,1fr)_...]), so a long brand name is never clipped by the 11rem floorsrc/main.tsxis byte-identical to the ui-std blockactions-menu.tsxagain (the first port put a blank line after every line, 182 -> 92 lines, no behaviour change)Why
At 1024 px with every fund selected: panel 60 -> 71 px, tabs bar 661 px content in 586 px visible with an 11 px scrollbar, title cell 176 px. After: panel 60 -> 60 px, tabs bar 465 / 465 with no scrollbar, title cell 219 px. Ported by ui-std
top-panel-tidy.ts(workspace tracker S32 and S33), reference PRs Schwab 93 and ETFs 95How it was checked
actions-menu-gates.sh(ui-std), ALL GATES PASSED iShares:35 passed, 0 failed; console errors: none
44 passed, 0 failed; console errors: none
19 passed, 0 failed; console errors: none
19 passed, 0 failed; console errors: none
19 passed, 0 failed; console errors: none
20 passed, 0 failed; console errors: none
subcheck.ts+subassert.tsPASS at 1500, 1280, 1024 and 390 px (checked on the built page after the change; before it failed withnav height 60 -> 71at 1024)