Skip to content

fix(ui): keep the top panel one height at 1024 px, tidy the actions menu block - #112

Merged
daggerok merged 1 commit into
mainfrom
fix/top-panel-tidy
Nov 15, 2026
Merged

daggerok merged 1 commit into
mainfrom
fix/top-panel-tidy

Conversation

@daggerok

Copy link
Copy Markdown
Owner

What changed

  • Between lg and xl the selected detail tabs (#selected-tabs-bar) drop their counts (<span class="lg:max-xl:hidden"> (N)</span>) and the bar hides its scrollbar ([scrollbar-width:none], [&::-webkit-scrollbar]:hidden; wheel, touch and keyboard focus still scroll it)
  • Between lg and xl the title column of the first panel is at least as wide as icon + title (lg:max-xl:grid-cols-[minmax(max-content,1fr)_...]), so a long brand name is never clipped by the 11rem floor
  • The actions menu block in src/main.tsx is byte-identical to the ui-std block actions-menu.tsx again (the first port put a blank line after every line, 182 -> 92 lines, no behaviour change)

Why

At 1024 px with every fund selected: panel 60 -> 71 px, tabs bar 661 px content in 586 px visible with an 11 px scrollbar, title cell 176 px. After: panel 60 -> 60 px, tabs bar 465 / 465 with no scrollbar, title cell 219 px. Ported by ui-std top-panel-tidy.ts (workspace tracker S32 and S33), reference PRs Schwab 93 and ETFs 95

How it was checked

actions-menu-gates.sh (ui-std), ALL GATES PASSED iShares:

  • ok: install
  • ok: test
  • ok: build-updater
  • ok: build-main
  • ok: build
  • ok: diff-check
  • ok: tc
  • ok: menu
    35 passed, 0 failed; console errors: none
  • ok: brand
    44 passed, 0 failed; console errors: none
  • ok: columns
    19 passed, 0 failed; console errors: none
  • ok: categories
    19 passed, 0 failed; console errors: none
  • ok: clear
    19 passed, 0 failed; console errors: none
  • ok: security
    20 passed, 0 failed; console errors: none
  • ok: pcheck
  • ok: subcheck
  • subcheck.ts + subassert.ts PASS at 1500, 1280, 1024 and 390 px (checked on the built page after the change; before it failed with nav height 60 -> 71 at 1024)

…enu block

At 1024 px with every fund selected the selected tabs lose their counts and
scrollbar and the title column fits its content, so the first panel stays one
height. The actions menu block returns to the verbatim ui-std block.
Ported by ui-std top-panel-tidy.ts.
@daggerok
daggerok merged commit 3382ef7 into main Nov 15, 2026
@daggerok
daggerok deleted the fix/top-panel-tidy branch November 15, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant