Repository navigation
fix(updater): a short Yahoo chart never shrinks the published history - #98
Merged
Merged
Conversation
The shared merge ran only when the Yahoo request had a period1 window, so with the default max a truncated Yahoo answer replaced the published history (2026-10-29: Franklin DVAL and USFI went from 999 rows to one). The merge now runs for every fresh chart; a full max answer starts at inception and comes back unchanged, one that does not join the published days counts as a failed chart and the fund is kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The chart step in scripts/update-data.ts calls mergeWindowedChart for every fresh chart, not only when period1 > 0; error text names the range and fresh day count. The Q25 range test is extended with a truncated default-range chart.
Why
With HISTORY_RANGE=max a truncated Yahoo answer replaced the published history (2026-10-29: Franklin DVAL and USFI, 999 rows to one). A full max answer starts at inception, so the merge returns it unchanged.
Checks