Repository navigation
feat(ui): 52-week range, low and high columns - #97
Merged
Merged
Conversation
Shared ui-std range52w block (ported with range52w.ts, as in Schwab): 52W Range (position of the last close in percent with a bar, sorted by it, amber bar for funds with less than 52 weeks of history), 52W Low and 52W High right after NAV, in the filters, the CSV export and the header tooltips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three catalog columns right after NAV from the range-52w
metricsof the feed, ported with the workspace scriptui-std/range52w.tsexactly as in Schwab (daggerok/Schwab#83):52W Range(percent over a bar, sorted by the number, empty cells last, amber bar for funds under 52 weeks),52W Low,52W High; filters, Columns menu, CSV export, tooltips.Why
Owner: the 52-week range everywhere, after looking at Schwab.
Checks
bun test,bun build --target=bun src/main.tsx,bun run build,TC_MODE=esnext tc/check.sh .clean,git diff --checkrange52w-uitest.tson the built app: 17 passed, 0 failed; console errors: none